From 94411d15fce25146dc0de7423d7891b3c3550e28 Mon Sep 17 00:00:00 2001 From: ElenaDiachenko Date: Thu, 25 Jan 2024 15:48:12 +0200 Subject: [PATCH 1/2] fix/withRNVRNConfig --- packages/sdk-react-native/src/adapters.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sdk-react-native/src/adapters.ts b/packages/sdk-react-native/src/adapters.ts index 99ff48e70d..5918ee1a55 100644 --- a/packages/sdk-react-native/src/adapters.ts +++ b/packages/sdk-react-native/src/adapters.ts @@ -11,7 +11,7 @@ const getApplicationId = () => { const getSkipLinkingDeps = () => { const skipLinkingEnv = process.env.RNV_SKIP_LINKING; if (skipLinkingEnv) { - const plugins = skipLinkingEnv.split(','); + const plugins = skipLinkingEnv.split(',').map((item) => item.trim()); return { dependencies: plugins.reduce((acc, plugin) => { From eb4200313d1380cec72f3167eff060b624604eb9 Mon Sep 17 00:00:00 2001 From: ElenaDiachenko Date: Fri, 26 Jan 2024 12:32:51 +0200 Subject: [PATCH 2/2] disable react-native-permissions for tvos --- packages/app-harness/renative.json | 7 ++++++- packages/app-harness/src/app/index.tvos.tsx | 13 +++++++++++++ packages/sdk-react-native/src/adapters.ts | 2 +- 3 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 packages/app-harness/src/app/index.tvos.tsx diff --git a/packages/app-harness/renative.json b/packages/app-harness/renative.json index bfc08072b5..28a51df4cc 100644 --- a/packages/app-harness/renative.json +++ b/packages/app-harness/renative.json @@ -54,7 +54,12 @@ }, "version": "2.3.0" }, - "react-native-permissions": "3.10.1", + "react-native-permissions": { + "ios": { + "podName": "RNPermissions" + }, + "version": "3.10.1" + }, "react-native": { "android": { "implementation": "// TEST" diff --git a/packages/app-harness/src/app/index.tvos.tsx b/packages/app-harness/src/app/index.tvos.tsx new file mode 100644 index 0000000000..a4685e0290 --- /dev/null +++ b/packages/app-harness/src/app/index.tvos.tsx @@ -0,0 +1,13 @@ +import React from 'react'; +import { Text, View } from 'react-native'; + +const App = () => { + return ( + + ReNative Harness + {`hermes: ${typeof HermesInternal === 'object' && HermesInternal !== null ? 'yes' : 'no'}`} + + ); +}; + +export default App; diff --git a/packages/sdk-react-native/src/adapters.ts b/packages/sdk-react-native/src/adapters.ts index 5918ee1a55..0d290b421b 100644 --- a/packages/sdk-react-native/src/adapters.ts +++ b/packages/sdk-react-native/src/adapters.ts @@ -15,7 +15,7 @@ const getSkipLinkingDeps = () => { return { dependencies: plugins.reduce((acc, plugin) => { - acc[`${plugin}`] = { + acc[plugin] = { platforms: { ios: null, },