Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splash screen can't be customized #1303

Closed
pauliusguzas opened this issue Dec 18, 2023 · 3 comments
Closed

Splash screen can't be customized #1303

pauliusguzas opened this issue Dec 18, 2023 · 3 comments
Assignees
@pavjacko @pauliusguzas @ElenaDiachenko
Labels
bug Something isn't working
Milestone
1.0

Comments

@pauliusguzas
Copy link
Collaborator

pauliusguzas commented Dec 18, 2023 •
edited by mihaiblaga89
Loading

Describe the bug
splash screen and project name can't be customized

To Reproduce

  1. go to template-starter
  2. do npx rnv run -p android or any other native platform
  3. observe as rnv uses default rn splash screen or no splashscreen

Expected behavior
splash screen can be customized

Screenshots or copy&paste
image

Desktop (please complete the following information):

  • OS: macOS Ventura
  • Node Version 18.14.2
  • RNV Version 1.0.0-rc.3
  • rnv/template-starter Version 1.0.0-rc.3

Note:

  • We'll need to check assets package if we have the splash images, otherwise we'll need to take the one from 0.37, otherwise design one
@pauliusguzas pauliusguzas added the bug Something isn't working label Dec 18, 2023
@pavjacko pavjacko added this to the 1.0 milestone Dec 18, 2023
@ElenaDiachenko ElenaDiachenko mentioned this issue Dec 19, 2023
Merged
@mihaiblaga89 mihaiblaga89 changed the title Splash screen and project name can't be customized Splash screen can't be customized Dec 20, 2023
@ElenaDiachenko ElenaDiachenko mentioned this issue Jan 16, 2024
Merged
@pauliusguzas
Copy link
Collaborator Author

Android device: splash screen exists
Android simulator: splash screen exists
iOS device: splash screen exists
iOS simulator: no splash screen
https://github.com/flexn-io/renative/assets/65670660/905a0251-1d4b-4ff7-9956-75ff3ef4b078

@pavjacko
Copy link
Member

@pauliusguzas can you reset ios sim and try again

@pauliusguzas
Copy link
Collaborator Author

ios simulator issue moved here #1457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavjacko pavjacko

@pauliusguzas pauliusguzas

@ElenaDiachenko ElenaDiachenko

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@pavjacko @pauliusguzas @ElenaDiachenko