-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling for web.load
when a non-existent task ID is provided.
#2154
Comments
What do you think @QingengWei |
Web API returns a 404 NOT FOUND error, but the Python client changes the error to None: https://github.com/flexcompute/tidy3d/blob/develop/tidy3d/web/core/http_util.py#L132-L133 |
That's funny, who knows where this comes from you or maybe even Lei Zheng in the first days of the web api? Could you propose a change? |
We should probably just handle status code correctly in the client though I'd say? |
I don't know the historical reason. I handle it from the web api and the client does not make any changes. |
I understand the reasoning, but returning a different error code just to avoid triggering
Instead of introducing workarounds, we should address the root cause by fixing the frontend to properly handle |
From the Python code now, it seems not to care about the error code but the error message. Changing python client code can fix the root cause. |
A user pointed out that when an incorrect task-id is provided to the
web.load
function, it leads to a Python error, with a lot of output messages that are not useful for the user.If possible, a clear message that the task-id doesn't exist could be more informative.
priority: small
The text was updated successfully, but these errors were encountered: