Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLSA attestation updates #26382

Open
6 tasks
sgress454 opened this issue Feb 17, 2025 · 3 comments
Open
6 tasks

SLSA attestation updates #26382

sgress454 opened this issue Feb 17, 2025 · 3 comments
Assignees
Labels
~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. #g-orchestration Orchestration product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature

Comments

@sgress454
Copy link
Contributor

sgress454 commented Feb 17, 2025

Goal

User story
As a Fleet user,
I want to have all Fleet binaries to have SLSA attestation
so that I know every binary I am using from Fleet has not been modified since being built.

Key result

  1. It looks like we're generating attestations on some workflows that run between releases, causing a lot of extra noise on the attestations page. Definitely the attestations in generate-desktop-targets.yml can be locked down to just happen during a release, and possibly others.

  2. The osqueryd and desktop app attestations for MacOS and Windows are only happening on the archive (zip) files, not the binaries themselves. We should attest the binaries in the archives so that users can verify the binaries on their hosts.

  3. We're attesting the unsigned windows Orbit binary, but we need to do the signed one instead, as that's what hosts end up downloading

Context

Changes

Engineering

  • Test plan is finalized
  • Feature guide changes: TODO
  • Database schema migrations: TODO
  • Load testing: TODO

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

  • Requires load testing: TODO
  • Risk level: Low / High TODO
  • Risk description: TODO

Test plan

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. Engineer: Added comment to user story confirming successful completion of test plan.
  2. QA: Added comment to user story confirming successful completion of test plan.
@sgress454 sgress454 added the ~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. label Feb 17, 2025
@sgress454 sgress454 self-assigned this Feb 17, 2025
@noahtalerman
Copy link
Member

@lukeheath I'd argue these follow ups are worth prioritizing. That way, we can say that users can attest all of fleetd:

  • currently just Orbit on macOS and Linux
  • currently just unsigned Orbit (not the base installer Fleet installs when Windows computers auto enroll to Fleet)

cc @sgress454

@lukeheath lukeheath added #g-orchestration Orchestration product group story A user story defining an entire feature :product Product Design department (shows up on 🦢 Drafting board) labels Feb 21, 2025
@lukeheath
Copy link
Member

Original issue description:

A couple of follow-up tasks for SLSA attestation of Fleet release artifacts:

  • It looks like we're generating attestations on some workflows that run between releases, causing a lot of extra noise on the attestations page. Definitely the attestations in generate-desktop-targets.yml can be locked down to just happen during a release, and possibly others.
  • The osqueryd and desktop app attestations for MacOS and Windows are only happening on the archive (zip) files, not the binaries themselves. We should attest the binaries in the archives so that users can verify the binaries on their hosts.
  • We're attesting the unsigned windows Orbit binary, but we need to do the signed one instead, as that's what hosts end up downloading

@lukeheath
Copy link
Member

@sgress454 @sharon-fdm Please make sure all sections are populated (including test plan) before bringing for estimation. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~engineering-initiated Engineering-initiated story, such as a bug, refactor, or contributor experience improvement. #g-orchestration Orchestration product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature
Projects
None yet
Development

No branches or pull requests

4 participants