Docker FMA installation fails with current install script

[jahzielv]

Fleet version: 4.63.0

Web browser and operating system: macOS

---

💥  Actual behavior

1. Installing Docker FMA fails and produces this output:

Installing software...
Failed
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>system-entities</key>
	<array>
		<dict>
			<key>content-hint</key>
			<string>EFI</string>
			<key>dev-entry</key>
			<string>/dev/disk4s1</string>
			<key>potentially-mountable</key>
			<true/>
			<key>unmapped-content-hint</key>
			<string>C12A7328-F81F-11D2-BA4B-00A0C93EC93B</string>
			<key>volume-kind</key>
			<string>msdos</string>
		</dict>
		<dict>
			<key>content-hint</key>
			<string>Apple_HFS</string>
			<key>dev-entry</key>
			<string>/dev/disk4s2</string>
			<key>mount-point</key>
			<string>/private/tmp/dmg_mount_t9Ma1q</string>
			<key>potentially-mountable</key>
			<true/>
			<key>unmapped-content-hint</key>
			<string>48465300-0000-11AA-AA11-00306543ECAC</string>
			<key>volume-kind</key>
			<string>hfs</string>
		</dict>
		<dict>
			<key>content-hint</key>
			<string>GUID_partition_scheme</string>
			<key>dev-entry</key>
			<string>/dev/disk4</string>
			<key>potentially-mountable</key>
			<false/>
			<key>unmapped-content-hint</key>
			<string>GUID_partition_scheme</string>
		</dict>
	</array>
</dict>
</plist>
"disk4" ejected.
false
Quitting application 'com.docker.docker'...
Application 'com.docker.docker' quit successfully.
ln: /usr/local/bin/docker: No such file or directory
ln: /usr/local/bin/docker-credential-desktop: No such file or directory
ln: /usr/local/bin/docker-credential-ecr-login: No such file or directory
ln: /usr/local/bin/docker-credential-osxkeychain: No such file or directory
ln: /usr/local/bin/hub-tool: No such file or directory
ln: /usr/local/cli-plugins/docker-compose: No such file or directory
ln: /usr/local/bin/kubectl.docker: No such file or directory

2. The Docker GUI doesn't quit when doing a re-install

🧑‍💻  Steps to reproduce

1. Install Docker on a macOS host via FMA
2. Note that the installation fails with the above output
3. Update the install script to remove the ln calls at the end
4. Install. Note that the install succeeds.
5. Open the Docker app on the host.
6. Re-install. Note that the re-install succeeds, but the GUI and menu bar icon are not closed.

🕯️ More info (optional)

🛠️ To fix

the edits would be to this migration + the script generation code). We need to

• Remove the symlinks added to the scripts
• add a call to quit_application 'com.electron.dockerdesktop' to make sure the GUI and menu bar close