RPM upgrade removes necessary binaries

[edwardsb]

Fleet version: all versions (orbit)

Web browser and operating system: N/A

---

💥  Actual behavior

dnf -y install fleet-osquery-0:1.1.0-1.x86_64
In the log shows:
Package fleet-osquery.x86_64 0.0.13-1 will be upgraded
 Package fleet-osquery.x86_64 1.1.0-1 will be an upgrade
2023-09-15T08:51:49-0400 SUBDEBUG Upgrade: fleet-osquery-1.1.0-1.x86_64
2023-09-15T08:52:01-0400 INFO Removed /etc/systemd/system/multi-user.target.wants/orbit.service.
Created symlink /etc/systemd/system/multi-user.target.wants/orbit.service → /etc/systemd/system/orbit.service.
2023-09-15T08:52:01-0400 SUBDEBUG Upgraded: fleet-osquery-0.0.13-1.x86_64
2023-09-15T08:52:01-0400 INFO Removed /etc/systemd/system/multi-user.target.wants/orbit.service.

RPM upgrades remove necessary binaries on accident due to the follwing %postun script:

fleet/orbit/pkg/packaging/linux_shared.go

Line 364 in b50e193

func writePostRemove(opt Options, path string) error {

🧑‍💻  Steps to reproduce

attempt to upgrade from one fleetd package to the next via dnf install

🕯️ More info (optional)

details about %postun here https://stackoverflow.com/questions/7398834/rpm-upgrade-uninstalls-the-rpm

and here https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/

Proposed solution

add conditional check on %postun script to only delete the files if the install is not an upgrade.

[fleet-release]

Upgrade removes keys,
Adding a check restores peace,
Fleet's rhythm won't cease.