From 28742fccb34506e1250e8dbc48fcb9ec583735cf Mon Sep 17 00:00:00 2001 From: Sam Pfluger <108141731+Sampfluger88@users.noreply.github.com> Date: Tue, 30 Apr 2024 23:07:28 -0500 Subject: [PATCH] Fix auto-approval + CODEOWNER blockage (#18668) - Remove redundant callouts for Luke in issue templates - Fix auto-approval + CODEOWNER blockage cc @lukeheath --- CODEOWNERS | 8 ++++---- website/config/custom.js | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 81aa6a12bf6b..11b2d3d815fa 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -77,12 +77,12 @@ go.mod @fleetdm/go /handbook/company/pricing-features-table.yml @noahtalerman # « Head of Product Design is current DRI for features table ############################################################################################## -# 🦿 Repo automation and change control settings +# 🌐 Repo automation and change control settings ############################################################################################## # /CODEOWNERS @mikermcneil # Covered in DRIs ############################################################################################## -# 🦿 Handbook +# 🌐 Handbook # # (see website/config/custom.js for DRIs of other paths not listed here) ############################################################################################## @@ -102,9 +102,9 @@ go.mod @fleetdm/go /handbook/product-design @sampfluger88 ############################################################################################## -# 🦿 GitHub issue templates +# 🌐 GitHub issue templates ############################################################################################## -/.github/ISSUE_TEMPLATE @mikermcneil @sampfluger88 @lukeheath # See https://github.com/fleetdm/fleet/pull/16203 +#/.github/ISSUE_TEMPLATE @mikermcneil @sampfluger88 @lukeheath # Covered in custom.js See https://github.com/fleetdm/fleet/pull/18668 ############################################################################################## # 🌐 GitHub workflows diff --git a/website/config/custom.js b/website/config/custom.js index c46e9c634b8d..01b925036dfb 100644 --- a/website/config/custom.js +++ b/website/config/custom.js @@ -170,7 +170,7 @@ module.exports.custom = { // 🌐 GitHub issue templates - //'.github/ISSUE_TEMPLATE': 'mikermcneil',// « Covered in CODEOWNERS (2023-08-10) + '.github/ISSUE_TEMPLATE': 'sampfluger88', }, @@ -262,9 +262,9 @@ module.exports.custom = { // GitHub issue templates '.github/ISSUE_TEMPLATE': ['mikermcneil', 'lukeheath', 'sampfluger88'], - '.github/ISSUE_TEMPLATE/bug-report.md': ['xpkoala','noahtalerman', 'lukeheath'], - '.github/ISSUE_TEMPLATE/feature-request.md': ['xpkoala','noahtalerman', 'lukeheath'], - '.github/ISSUE_TEMPLATE/release-qa.md': ['xpkoala','lukeheath','noahtalerman', 'lukeheath'], + '.github/ISSUE_TEMPLATE/bug-report.md': ['xpkoala','noahtalerman'], + '.github/ISSUE_TEMPLATE/feature-request.md': ['xpkoala','noahtalerman'], + '.github/ISSUE_TEMPLATE/release-qa.md': ['xpkoala','noahtalerman'], }, confidentialGithubRepoMaintainersByPath: {// fleetdm/confidential