Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn and use "oldest possible" dependency upon failure to find dependency #4

Open
Schwad opened this issue Jun 23, 2022 · 2 comments
Open

Comments

@Schwad
Copy link
Collaborator

Schwad commented Jun 23, 2022

This is in the case that there is a valid rubygem, but the date is simply too old.

The current behavior is a reversion to the most recent stable gem. After pairing with @flavorjones; I think we agreed that any user of this gem probably would prefer the oldest-available version.

However we don't want this to be done silently, so to fix this issue the plugin should:

  • revert to oldest
  • warn that it is reverting to oldest, with a link to the index of rubygems releases

interesting context

currently the oldest possible gem version is July 25, 2009 in the rubygems api. That is because of the rubyforge migration (I believe). I'm pairing with someone on rubygems.org tomorrow to try and rectify that, which may actually solve 30-50% of this problem too

@Schwad
Copy link
Collaborator Author

Schwad commented Jul 5, 2022

Let's link this to this rubygems.org issue

I still think there's something worth tracking here but if this gets merged it could solve the vast majority of cases here! because we'd actually be getting those pre-july-2009 gem versions. And then the PR resolving this could just be catching an edge case issue.

@Schwad
Copy link
Collaborator Author

Schwad commented Jul 18, 2022

Idea: we actually have the power to do this in the API already ; using built_at

e.g.

if gem_version.created_at == RUBYGEMS_IMPORT_DATE
  gem_version.built_at
else
  gem_version.created_at
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant