Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-implement ephys.* and ms4alg.* processors using new processor manager #59

Open
magland opened this issue Aug 13, 2018 · 4 comments
Open
Assignees

Comments

@magland
Copy link
Collaborator

magland commented Aug 13, 2018

Use a slightly different namespace, so we can test the equivalence, and then we'll replace the existing with the new.

These include the following:

ephys.bandpass_filter
ephys.compare_ground_truth
ephys.compute_cluster_metrics
ephys.compute_cross_correlograms
ephys.compute_templates
ephys.convert_array
ephys.synthesize_random_firings
ephys.synthesize_random_waveforms
ephys.synthesize_timeseries
ephys.whiten

ms4alg.apply_label_map
ms4alg.create_label_map
ms4alg.sort

@wysota
Copy link
Collaborator

wysota commented Aug 17, 2018

Initial implementation of the aforementioned processors has been completed and is available in 'mlprocessors' branch of respective repositories. Once it is confirmed the ports work as expected, I'll work on improving the implementation.

@magland
Copy link
Collaborator Author

magland commented Aug 17, 2018

Excellent. Can we merge this into the master branch? Then I will change all my pipelines to use ephys_new.* And if everything seems okay for around a week, we will make the namespace change, and change ephys.* to ephys_old.* and ephys_new.* to ephys.. Then after another week or so we will then delete the ephys_old.

@wysota
Copy link
Collaborator

wysota commented Aug 17, 2018

I'd feel safer if you tested it slightly first but if you feel confident about it then go ahead. Once I know it works, I'll fiddle with the implementation as currently everything is in a single file and wraps your original calls. I want to put implementations into dedicated files.

@magland
Copy link
Collaborator Author

magland commented Aug 18, 2018

Okay, I'll try to get to this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants