Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] More versatile GQA group sizes #140

Closed
yzh119 opened this issue Feb 27, 2024 · 1 comment
Closed

[Feature Request] More versatile GQA group sizes #140

yzh119 opened this issue Feb 27, 2024 · 1 comment
Assignees
@yzh119

Comments

@yzh119
Copy link
Collaborator

yzh119 commented Feb 27, 2024

We only support gqa_group_size of 1/4/8 at the moment but some models use other choices (e.g. Yi uses 7), we should support other gqa_group_size as well.
@yzh119 yzh119 self-assigned this Feb 27, 2024
@yzh119 yzh119 mentioned this issue Feb 27, 2024
Closed
3 tasks
@yzh119
Copy link
Collaborator Author

yzh119 commented Jun 15, 2024

Done in #301 .

@yzh119 yzh119 closed this as completed Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yzh119 yzh119

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yzh119