Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some tracks for improvement! #4

Open
SeifESlimene opened this issue Sep 2, 2021 · 2 comments
Open

some tracks for improvement! #4

SeifESlimene opened this issue Sep 2, 2021 · 2 comments

Comments

@SeifESlimene
Copy link

SeifESlimene commented Sep 2, 2021

Actually, I just fixed the other issue in place.
In fact, it was just a b tag that was added to HTML so I had to change the indexes here str(h2)[5:11] from 5:11 to 8:14 to extract the correct total number of movies.
I think this tool does nothing but download the .torrent file, not the movie and this is not quite practical.
I didn't expect that!
This tool should use some torrent client with (magnet link constructed from data returned from YTS API or the downloaded torrent).
I suggest using transmission as it's open-source and it has a nice command line!

@flashblaze
Copy link
Owner

Thanks a lot for your suggestion! I agree the title might be misleading but I had created it just to put some "good" use to my Python knowledge (which was very limited at that time, and so is now if I'm being honest) by creating a small CLI for me to use personally instead of having to visit the website.

Coming to your solution, although I've used bs4 in my implementation, I saw yesterday that the API supports query_term as a parameter which would effectively render bs4 implementation useless. I'll update the code for torrent file and make it at least usable.

Regarding the torrent client part, I'll have a look into it and get back to you. Sorry for the delay I might have caused.
Thanks for taking the time and filing such helpful issues and giving your suggestions.

@SeifESlimene SeifESlimene changed the title this tool should do it's work! some tracks for improvement! Sep 2, 2021
@SeifESlimene
Copy link
Author

SeifESlimene commented Sep 2, 2021

@flashblaze sorry for the title I forgot to edit it, I was editing the issue because I was thinking the app didn't work properly...

And yeah the YTS API was improved a lot since so I Imagine much of the code is useless by now.

About the CLI, I looked into it and I experience a little bit with transmission-remote, but there is a problem with download it's very low I don't know, but I will investigate it further to see what is the problem if it's ok we will have a full solution :)

Of course, the problem now is with the exact name of the movie that I have to type it correctly otherwise "Title Is Not Found".
We have to make it much smarter by using Regex and give suggestions and support of autocomplete :)
Many stuff will come later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants