Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please don't use open-uri #8

Open
postmodern opened this issue May 27, 2016 · 0 comments
Open

Please don't use open-uri #8

postmodern opened this issue May 27, 2016 · 0 comments

Comments

@postmodern
Copy link

I noticed you request /robots.txt using open-uri. Since open-uri overrides Kernel#open, it also allows for possible command injection (ex: open("| ls")). I think using Net::HTTP.get would be Good Enough (tm).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@postmodern