Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fivetran Zendesk package references an old status for on hold tickets #112

Closed
2 of 4 tasks
mpavillet opened this issue Sep 20, 2023 · 1 comment
Closed
2 of 4 tasks
Labels
bug Something isn't working error:forced

Comments

@mpavillet
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

See slack thread here for reference: https://getdbt.slack.com/archives/C01D1R2JLLA/p1695159048651189

The model int_zendesk__requester_wait_time_filtered_statuses looks for a status value = 'on-hold' . It turns out that this value doesn't exist in Zendesk. It is 'hold'.

https://github.com/fivetran/dbt_zendesk/blob/v0.11.2/models/sla_policy/requester_wait_time/int_zendesk__requester_wait_time_filtered_statuses.sql#L30

Relevant error log or model output

No response

Expected behavior

The filtered status looks for valid statuses in Zendesk, in this case, 'hold' instead of 'on-hold'

dbt Project configurations

N/A

Package versions

  • package: fivetran/zendesk
    version: 0.10.0

What database are you using dbt with?

snowflake

dbt Version

1.3

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@mpavillet mpavillet added the bug Something isn't working label Sep 20, 2023
@fivetran-joemarkiewicz
Copy link
Contributor

@mpavillet thank you for raising this issue with our team. We have been able to incorporate this update in the latest release of the dbt_zendesk package. You should be able to see the package accounting for the proper hold status in calculations.

As such, I will close this ticket. Please let us know if you see that this issue still persists after upgrading. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working error:forced
Projects
None yet
Development

No branches or pull requests

2 participants