[Feature] Remove the age_groups
and age
coalesce in adgroup_history staging model
#25
Closed
1 of 4 tasks
Labels
Is there an existing feature request for this?
Describe the Feature
Back in release v0.4.0 we added the new
age_groups
field which was meant to replace the soon to be deprecatedage
field. As this was over a year ago we should be comfortable removing theage
field from the age_group coalesce within the stg_tiktok_ads__ad_group_history model.How would you implement this feature?
To implement this feature we will simply remove the
age
field from the coalesce and no longer leverage a coalesce, instead we will simply reference the age_groups field.dbt_tiktok_ads_source/models/stg_tiktok_ads__ad_group_history.sql
Line 39 in ef98cc3
Additionally, we will want to remove the
age
field from the fill staging macro for the adgroup history table.dbt_tiktok_ads_source/macros/get_ad_group_history_columns.sql
Line 20 in ef98cc3
Describe alternatives you've considered
Leaving the field in and not removing it from the coalesce.
Are you interested in contributing this feature?
Anything else?
While this is a feature request, we should also treat this as an enhancement which will address a number of issues raised by customers due to the
age_groups
field being interpreted as a json datatype. Customers have reported experiencing the following error type:Therefore, removing this coalesce will ensure only the one datatype is inferred and there is no clash when trying to coalesce fields. I was able to test this theory locally with a JSON datatype and confirmed that removing the
age
coalesce ensured the data model succeeded as expected.The text was updated successfully, but these errors were encountered: