Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Shopify v2022-07 -> v2023-04 API Update Schema Change Considerations #60

Closed
1 of 4 tasks
fivetran-joemarkiewicz opened this issue Jun 6, 2023 · 2 comments
Closed
1 of 4 tasks
Assignees
Labels
priority:p4 Affects few users; pick up when available status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Shopify is upgrading from their v2022-07 to v2023-04 API. This is resulting in a number of deprecations and new field additions. For this package (and likely the downstream dbt_shopify package), the following changes will need to be made to reflect the connector changes:

  • OrderLine Resource (ORDER_LINE Table)
    • origin_location (deprecated)
    • destination_location (deprecated)
    • fulfillment_service (deprecated)
  • Order Resource
    • total_price_usd (deprecated)
    • processing_method (2023-04) (unsupported)
  • ProductVariant Resource (PRODUCT_VARIANT Table)
    • title (deprecated)

Describe alternatives you've considered

This will still likely work following the API upgrade, but it would be best to upgrade to ensure our package is using the latest fields provided by the API and connector.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-joemarkiewicz
Copy link
Contributor Author

Notes from the duplicate Issue from the source package are included below

In June 2023, the connector was migrated to a new Shopify API version, in which the following relevant columns were deprecated

order_line.fulfillment_service
order_line.destination_location_* fields
order_line.origin_location_* fields
order.total_price_usd
order. processing_method
customer.lifetime_duration
we should mark them as deprecated in the src yml file and remove them from staging models

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the status:in_progress Currently being worked on label Jun 22, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz added priority:p4 Affects few users; pick up when available update_type:models Primary focus requires model updates labels Jun 22, 2023
@fivetran-joemarkiewicz
Copy link
Contributor Author

The latest release incorporates these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p4 Affects few users; pick up when available status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates
Projects
None yet
Development

No branches or pull requests

1 participant