Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miri flag passing changed #28

Closed
RalfJung opened this issue Sep 21, 2020 · 1 comment
Closed

Miri flag passing changed #28

RalfJung opened this issue Sep 21, 2020 · 1 comment

Comments

@RalfJung
Copy link

RalfJung commented Sep 21, 2020

Passing flags to Miri changed to make cargo miri test more compatible with cargo test. hence this will need adjusting:

- cargo miri test -- -Zmiri-seed=23

However, in fact you should not have to pass a seed at all any more. Just a plain cargo miri test should do it. (cargo miri setup also is not needed as a separate step any more.)

The old way still works for now, but is deprecated and will be removed in the future.

@RalfJung
Copy link
Author

Heads-up: I am planning to remove the compatibility hack that made passing Miri flags as cargo arguments still work (rust-lang/miri#1769). Once this lands, CI here will break.

Fixing it is easy: just use MIRIFLAGS="-Zmiri-seed=23" cargo miri test instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant