From fe895689487a547125b09d725fdd5a255d7c9ad3 Mon Sep 17 00:00:00 2001 From: Phaniraj Govindaraju Date: Tue, 21 May 2024 13:15:02 +1000 Subject: [PATCH 1/6] Remove constructor endpoint --- src/fireblocks-sdk.ts | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/fireblocks-sdk.ts b/src/fireblocks-sdk.ts index e5aeb0f3..d4cd0da2 100644 --- a/src/fireblocks-sdk.ts +++ b/src/fireblocks-sdk.ts @@ -1885,19 +1885,6 @@ export class FireblocksSDK { return await this.apiClient.issueDeleteRequest(`/v1/tokenization/templates/${templateId}`); } - /** - * @deprecated Use getContractTemplateDeployFunction instead - * - * Get contract template constructor by id - * @param templateId - * @param withDocs - * - * @returns {AbiFunction} - */ - public async getContractTemplateConstructor(templateId: string, withDocs: boolean = false): Promise { - return await this.apiClient.issueGetRequest(`/v1/tokenization/templates/${templateId}/constructor?withDocs=${withDocs}`); - } - /** * Get contract template deploy function by id * @param templateId From db27bb7883ceedf4bd9bb9159370652c51ce4ad6 Mon Sep 17 00:00:00 2001 From: Phaniraj Govindaraju Date: Tue, 21 May 2024 13:26:06 +1000 Subject: [PATCH 2/6] Remove constructorParams --- src/types.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/types.ts b/src/types.ts index cbd2c6df..e2112b4a 100644 --- a/src/types.ts +++ b/src/types.ts @@ -1799,7 +1799,6 @@ interface VendorDto { export interface ContractDeployRequest { assetId: string; vaultAccountId: string; - constructorParameters?: object[]; deployFunctionParameters?: object[]; } From c2e552eda3bee2c2dc86c9a0bcbbef354bf1f1cc Mon Sep 17 00:00:00 2001 From: Phaniraj Govindaraju Date: Tue, 21 May 2024 15:35:29 +1000 Subject: [PATCH 3/6] Change EVMTokenCreateParamsDto --- src/types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/types.ts b/src/types.ts index e2112b4a..49a545f4 100644 --- a/src/types.ts +++ b/src/types.ts @@ -1987,7 +1987,7 @@ export type ParameterWithValueList = ParameterWithValue[] | ParameterWithValueLi interface EVMTokenCreateParamsDto { contractId: string; - constructorParams?: Array; + deployFunctionParams?: Array; } export interface ReadCallFunctionDto { From dfa7e57e85ab53be8d6d3da3c95c7aa869f3056e Mon Sep 17 00:00:00 2001 From: Phaniraj Govindaraju Date: Tue, 21 May 2024 15:42:33 +1000 Subject: [PATCH 4/6] Update parameter name --- src/types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/types.ts b/src/types.ts index 49a545f4..de4f92ee 100644 --- a/src/types.ts +++ b/src/types.ts @@ -1799,7 +1799,7 @@ interface VendorDto { export interface ContractDeployRequest { assetId: string; vaultAccountId: string; - deployFunctionParameters?: object[]; + deployFunctionParams?: object[]; } export interface SupportedBlockchain { From 3755323295620aeee8f1a0a1ffa4c14fb730b2d3 Mon Sep 17 00:00:00 2001 From: Phaniraj Govindaraju Date: Wed, 22 May 2024 15:03:03 +1000 Subject: [PATCH 5/6] Adding back constructor params to support integration tests --- src/types.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/types.ts b/src/types.ts index de4f92ee..385c9ca0 100644 --- a/src/types.ts +++ b/src/types.ts @@ -1799,6 +1799,7 @@ interface VendorDto { export interface ContractDeployRequest { assetId: string; vaultAccountId: string; + constructorParameters?: object[]; deployFunctionParams?: object[]; } @@ -1987,6 +1988,7 @@ export type ParameterWithValueList = ParameterWithValue[] | ParameterWithValueLi interface EVMTokenCreateParamsDto { contractId: string; + constructorParams?: Array; deployFunctionParams?: Array; } From 5fb890a0058980fd89ab281a6f4c22a47c5b7412 Mon Sep 17 00:00:00 2001 From: Phaniraj Govindaraju Date: Thu, 23 May 2024 19:39:58 +1000 Subject: [PATCH 6/6] Removing constructor params --- src/types.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/types.ts b/src/types.ts index 385c9ca0..de4f92ee 100644 --- a/src/types.ts +++ b/src/types.ts @@ -1799,7 +1799,6 @@ interface VendorDto { export interface ContractDeployRequest { assetId: string; vaultAccountId: string; - constructorParameters?: object[]; deployFunctionParams?: object[]; } @@ -1988,7 +1987,6 @@ export type ParameterWithValueList = ParameterWithValue[] | ParameterWithValueLi interface EVMTokenCreateParamsDto { contractId: string; - constructorParams?: Array; deployFunctionParams?: Array; }