Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Missing sourceAddress in TransactionResponse #85

Closed
prevostc opened this issue Apr 14, 2022 · 1 comment · Fixed by #94
Closed

[Bug] Missing sourceAddress in TransactionResponse #85

prevostc opened this issue Apr 14, 2022 · 1 comment · Fixed by #94
Assignees
Labels
bug Something isn't working

Comments

@prevostc
Copy link

Describe the bug
Typescript type doesn't match the returned value.

To Reproduce
Steps to reproduce the behavior:
Do this

const transactions = await fireblocks.getTransactions({
        status: args.status,
        after: from
});

Compare the return value with the TransactionResponse type. They don't match.

Expected behavior
Ts type should match the API response more closely and provide similar data structures.

Version:

  • fireblocks-sdk version: 2.0.0
  • Now using node v16.14.0 (npm v8.3.1)
@prevostc prevostc added the bug Something isn't working label Apr 14, 2022
@yarinvak
Copy link
Contributor

yarinvak commented May 30, 2022

A fix is released in v2.3.1, thanks for reporting the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants