Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] type field in AddressResponse is number, but was string in soon-to-be-deprecated DepositAddressResponse #263

Open
vihangpatil opened this issue Mar 4, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@vihangpatil
Copy link

Describe the bug
getDepositAddresses is being deprecated and replaced by its paginated version getPaginatedAddresses.
Original interface DepositAddressResponse had type?: string but the replacement interface AddressResponse has type?: number.
The raw json has string values such as Permanent.

API documentation shows correct datatype - type?: string.
But the Response 200 object is array of AddressResponse instead of object which has 2 fields - addresses: AddressResponse[] and paging...

paging?: {
  before?: string;
  after?: string;
};

Deprecated API: https://developers.fireblocks.com/reference/get_vault-accounts-vaultaccountid-assetid-addresses

Replacement API: https://developers.fireblocks.com/reference/get_vault-accounts-vaultaccountid-assetid-addresses-paginated

To Reproduce
Steps to reproduce the behavior:

  • Check raw json response for replacement API.

Expected behavior

  • In interface AddressResponse, type?: number should be changed to type?: string.
  • 200 Response documentation to be updated for replacement API.

Version:

  • fireblocks-sdk version: 5.21.0
@vihangpatil vihangpatil added the bug Something isn't working label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants