Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where tester.groups can be undefined #8195

Merged
merged 5 commits into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
- Fixes symbol generation when uploading Unity 6 symbols to Crashlytics.
- Fixed SSR issues in Angular 19 by adding support for default and reqHandler exports. (#8145)
- Added Angular 19 as supported version. (#8145)
- Fixed `appdistribution:testers:list` raising an error when a tester is not part of any group. (#8191)
2 changes: 1 addition & 1 deletion src/appdistribution/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
export interface Tester {
name: string;
displayName?: string;
groups: string[];
groups?: string[];
lastActivityTime: Date;
}

Expand All @@ -100,7 +100,7 @@
inconclusiveReason?: string;
}

export function mapDeviceToExecution(device: TestDevice): DeviceExecution {

Check warning on line 103 in src/appdistribution/types.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Missing JSDoc comment
return {
device: {
model: device.model,
Expand Down
2 changes: 1 addition & 1 deletion src/commands/appdistribution-testers-list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@
const spinner = ora("Preparing the list of your App Distribution testers").start();
try {
testersResponse = await appDistroClient.listTesters(projectName, group);
} catch (err: any) {

Check warning on line 23 in src/commands/appdistribution-testers-list.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unexpected any. Specify a different type
spinner.fail();
throw new FirebaseError("Failed to list testers.", {
exit: 1,
original: err,

Check warning on line 27 in src/commands/appdistribution-testers-list.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe assignment of an `any` value
});
}
spinner.succeed();
Expand All @@ -47,7 +47,7 @@

for (const tester of testers) {
const name = tester.name.split("/").pop();
const groups = tester.groups
const groups = (tester.groups || [])
.map((grp) => grp.split("/").pop())
.sort()
.join(";");
Expand Down
Loading