Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux install using automatic script, but recommended using npm #7293

Closed
ImBIOS opened this issue Jun 7, 2024 · 2 comments · Fixed by #7493
Closed

Linux install using automatic script, but recommended using npm #7293

ImBIOS opened this issue Jun 7, 2024 · 2 comments · Fixed by #7493

Comments

@ImBIOS
Copy link

ImBIOS commented Jun 7, 2024

[REQUIRED] Environment info

firebase-tools: 13.10.2

Platform: Ubuntu 22.04.4 LTS

[REQUIRED] Test case

Sorry, currently I don't know how to make tests like this.

[REQUIRED] Steps to reproduce

Have an outdated firebase-cli/firebase-tools

[REQUIRED] Expected behavior

   ╭───────────────────────────────────────────────────────────────────╮
   │                                                                   │
   │                Update available 13.10.2 → 13.11.1                 │
   │    To update to the latest version using automatic script, run    │
   │       curl -sL https://firebase.tools | upgrade=true bash         │
   │   For other CLI management options, visit the CLI documentation   │
   │                                                                   │
   │                                                                   │
   │                                                                   │
   ╰───────────────────────────────────────────────────────────────────╯


󰀵  󱑍 16:04  ﱮ codelab-friendlyeats-web    main ? via 🍞 v1.1.12 via  v20.14.0   1m29s 
 ✗  which firebase
/usr/local/bin/firebase

󰀵  󱑍 16:05  ﱮ codelab-friendlyeats-web    main ? via 🍞 v1.1.12 via  v20.14.0 
 ➜  curl -sL https://firebase.tools | upgrade=true bash

[REQUIRED] Actual behavior

   ╭───────────────────────────────────────────────────────────────────╮
   │                                                                   │
   │                Update available 13.10.2 → 13.11.1                 │
   │          To update to the latest version using npm, run           │
   │                   npm install -g firebase-tools                   │
   │   For other CLI management options, visit the CLI documentation   │
   │                                                                   │
   │                                                                   │
   │                                                                   │
   ╰───────────────────────────────────────────────────────────────────╯


󰀵  󱑍 16:04  ﱮ codelab-friendlyeats-web    main ? via 🍞 v1.1.12 via  v20.14.0   1m29s 
 ✗  which firebase
/usr/local/bin/firebase

󰀵  󱑍 16:05  ﱮ codelab-friendlyeats-web    main ? via 🍞 v1.1.12 via  v20.14.0 
 ➜  curl -sL https://firebase.tools | upgrade=true bash
@aalej
Copy link
Contributor

aalej commented Jun 10, 2024

Thanks for the report @ImBIOS. I agree that a log message showing the correct update method would be expected behavior here. I'll discuss this with our engineering team so that the message can be improved.

In the meantime, if anyone would like to try to fix the message, feel free to submit a PR!

@joehan
Copy link
Contributor

joehan commented Jun 11, 2024

Some code pointers for implementing this:

Thanks for reporting + suggesting this @ImBIOS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants