Skip to content

Commit

Permalink
Fix issue where tester.groups can be undefined (#8195)
Browse files Browse the repository at this point in the history
* Fix issue where tester.groups can be undefined

* Added changelog entry

* Format changelog entry

* Update src/commands/appdistribution-testers-list.ts

---------

Co-authored-by: joehan <joehanley@google.com>
  • Loading branch information
aalej and joehan authored Feb 10, 2025
1 parent 6742456 commit 6ba30b9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
- Fixes symbol generation when uploading Unity 6 symbols to Crashlytics. (#7867)
- Fixed SSR issues in Angular 19 by adding support for default and reqHandler exports. (#8145)
- Added Angular 19 as supported version. (#8145)
- Fixed `appdistribution:testers:list` raising an error when a tester is not part of any group. (#8191)
2 changes: 1 addition & 1 deletion src/appdistribution/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export interface ListTestersResponse {
export interface Tester {
name: string;
displayName?: string;
groups: string[];
groups?: string[];
lastActivityTime: Date;
}

Expand Down
2 changes: 1 addition & 1 deletion src/commands/appdistribution-testers-list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function printTestersTable(testers: Tester[]): void {

for (const tester of testers) {
const name = tester.name.split("/").pop();
const groups = tester.groups
const groups = (tester.groups ?? [])
.map((grp) => grp.split("/").pop())
.sort()
.join(";");
Expand Down

0 comments on commit 6ba30b9

Please sign in to comment.