From e5fc29090007d04ff495961cf217d18711753d61 Mon Sep 17 00:00:00 2001 From: wu-hui <53845758+wu-hui@users.noreply.github.com> Date: Thu, 4 Jan 2024 10:19:55 -0500 Subject: [PATCH] Disable nightly run with PR (#7876) * Disable nightly run with PR * triggers a firestore change * feedback * try again --- .github/workflows/test-changed-firestore.yml | 6 ++++-- packages/firestore/test/integration/api/query.test.ts | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-changed-firestore.yml b/.github/workflows/test-changed-firestore.yml index f27bb37049a..c34e4e79dce 100644 --- a/.github/workflows/test-changed-firestore.yml +++ b/.github/workflows/test-changed-firestore.yml @@ -14,7 +14,9 @@ name: Test Firestore -on: pull_request +on: + workflow_dispatch: + pull_request: env: artifactRetentionDays: 14 @@ -138,7 +140,7 @@ jobs: test-name: ["test:browser:nightly"] runs-on: ubuntu-latest needs: build - if: ${{ needs.build.outputs.changed == 'true'}} + if: ${{ github.event_name != 'pull_request' }} steps: - name: Set up Node (16) uses: actions/setup-node@v3 diff --git a/packages/firestore/test/integration/api/query.test.ts b/packages/firestore/test/integration/api/query.test.ts index 8ec9df262be..7f1d10dd7c1 100644 --- a/packages/firestore/test/integration/api/query.test.ts +++ b/packages/firestore/test/integration/api/query.test.ts @@ -411,7 +411,7 @@ apiDescribe('Queries', persistence => { }); }); - it('maintains correct DocumentChange indices', async () => { + it('maintains correct DocumentChange indexes', async () => { const testDocs = { 'a': { order: 1 }, 'b': { order: 2 },