From 7dd8c1147c67a65a775bafc0c3deca06545926e4 Mon Sep 17 00:00:00 2001 From: Daniel La Rocque Date: Fri, 25 Oct 2024 13:42:10 -0400 Subject: [PATCH 1/3] Remove modifiers from compat overloads --- scripts/build/create-overloads.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/build/create-overloads.ts b/scripts/build/create-overloads.ts index a66bda6dfe0..563ae50b91d 100644 --- a/scripts/build/create-overloads.ts +++ b/scripts/build/create-overloads.ts @@ -178,7 +178,7 @@ function keepPublicFunctionsTransformer( overloads.push( factory.updateFunctionDeclaration( node, - ts.getModifiers(node), + (ts.canHaveDecorators(node) ? ts.getDecorators(node) : []), node.asteriskToken, node.name, node.typeParameters, From c6de0cb3b4e434f4bd47cd6a2cf3a1e2672b2775 Mon Sep 17 00:00:00 2001 From: Daniel La Rocque Date: Fri, 25 Oct 2024 13:55:26 -0400 Subject: [PATCH 2/3] format --- scripts/build/create-overloads.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/build/create-overloads.ts b/scripts/build/create-overloads.ts index 563ae50b91d..eafcf164948 100644 --- a/scripts/build/create-overloads.ts +++ b/scripts/build/create-overloads.ts @@ -178,7 +178,7 @@ function keepPublicFunctionsTransformer( overloads.push( factory.updateFunctionDeclaration( node, - (ts.canHaveDecorators(node) ? ts.getDecorators(node) : []), + ts.canHaveDecorators(node) ? ts.getDecorators(node) : [], node.asteriskToken, node.name, node.typeParameters, From 46986ebc90f0af8babfda268458f861411432014 Mon Sep 17 00:00:00 2001 From: Daniel La Rocque Date: Fri, 25 Oct 2024 14:30:03 -0400 Subject: [PATCH 3/3] Add changeset --- .changeset/tame-paws-nail.md | 53 ++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 .changeset/tame-paws-nail.md diff --git a/.changeset/tame-paws-nail.md b/.changeset/tame-paws-nail.md new file mode 100644 index 00000000000..0a2ad08c756 --- /dev/null +++ b/.changeset/tame-paws-nail.md @@ -0,0 +1,53 @@ +--- +'@firebase/analytics': patch +'@firebase/analytics-compat': patch +'@firebase/analytics-interop-types': patch +'@firebase/analytics-types': patch +'@firebase/app': patch +'@firebase/app-check': patch +'@firebase/app-check-compat': patch +'@firebase/app-check-interop-types': patch +'@firebase/app-check-types': patch +'@firebase/app-compat': patch +'@firebase/app-types': patch +'@firebase/auth': patch +'@firebase/auth-compat': patch +'@firebase/auth-interop-types': patch +'@firebase/auth-types': patch +'@firebase/component': patch +'@firebase/data-connect': patch +'@firebase/database': patch +'@firebase/database-compat': patch +'@firebase/database-types': patch +'firebase': patch +'@firebase/firestore': patch +'@firebase/firestore-compat': patch +'@firebase/firestore-types': patch +'@firebase/functions': patch +'@firebase/functions-compat': patch +'@firebase/functions-types': patch +'@firebase/installations': patch +'@firebase/installations-compat': patch +'@firebase/installations-types': patch +'@firebase/logger': patch +'@firebase/messaging': patch +'@firebase/messaging-compat': patch +'@firebase/messaging-interop-types': patch +'@firebase/performance': patch +'@firebase/performance-compat': patch +'@firebase/performance-types': patch +'@firebase/remote-config': patch +'@firebase/remote-config-compat': patch +'@firebase/remote-config-types': patch +'@firebase/rules-unit-testing': patch +'@firebase/storage': patch +'@firebase/storage-compat': patch +'@firebase/storage-types': patch +'@firebase/template': patch +'@firebase/template-types': patch +'@firebase/util': patch +'@firebase/vertexai': patch +'@firebase/webchannel-wrapper': patch +--- + +Upgrade to TypeScript 5.5.4