Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Port 'RCNConfigSettings' #14262

Merged
merged 19 commits into from
Dec 20, 2024
Prev Previous commit
Next Next commit
Add atomic TODOs
  • Loading branch information
ncooke3 committed Dec 18, 2024
commit 949168d02d1511a4038159ac2bd34ac39beae889
3 changes: 3 additions & 0 deletions FirebaseRemoteConfig/SwiftNew/ConfigSettings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,12 @@ let RCNHTTPDefaultConnectionTimeout: TimeInterval = 60

// MARK: - Data required by config request.

// TODO(ncooke3): This property was atomic in ObjC.
/// InstallationsID.
/// - Note: The property is atomic because it is accessed across multiple threads.
@objc public var configInstallationsIdentifier: String?

// TODO(ncooke3): This property was atomic in ObjC.
/// Installations token.
/// - Note: The property is atomic because it is accessed across multiple threads.
@objc public var configInstallationsToken: String?
Expand All @@ -93,6 +95,7 @@ let RCNHTTPDefaultConnectionTimeout: TimeInterval = 60

// MARK: - Throttling Properties

// TODO(ncooke3): This property was atomic in ObjC.
/// Throttling intervals are based on https://cloud.google.com/storage/docs/exponential-backoff
/// Returns true if client has fetched config and has not got back from server. This is used to
/// determine whether there is another config task infight when fetching.
Expand Down