Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readd pip install and sdist test #816

Closed
timkpaine opened this issue Nov 14, 2019 · 2 comments
Closed

Readd pip install and sdist test #816

timkpaine opened this issue Nov 14, 2019 · 2 comments
Labels
bug Concrete, reproducible bugs Python

Comments

@timkpaine
Copy link
Member

966d533#diff-b23a161aa71df80df5c594015a1cdb7b
@timkpaine timkpaine added bug Concrete, reproducible bugs Python labels Nov 14, 2019
@timkpaine timkpaine changed the title Readd pip install test -- don't delete, this has regressed Readd pip install and sdist test -- don't delete, this has regressed Nov 14, 2019
@timkpaine timkpaine changed the title Readd pip install and sdist test -- don't delete, this has regressed Readd pip install and sdist test Nov 14, 2019
@timkpaine
Copy link
Member Author

the pip install and the sdist command are to ensure the source build works. in deleting them (and the commits that went along with it) we have broken the source dist and pip install.

@texodus
Copy link
Member

texodus commented Nov 23, 2019

Please track these in projects.

@texodus texodus closed this as completed Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@texodus @timkpaine