Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupyterlab-phosphor should not attempt to load empty array #742

Closed
timkpaine opened this issue Sep 25, 2019 · 0 comments
Closed

Jupyterlab-phosphor should not attempt to load empty array #742

timkpaine opened this issue Sep 25, 2019 · 0 comments
Labels
bug Concrete, reproducible bugs JS Jupyter

Comments

@timkpaine
Copy link
Member

https://github.com/finos/perspective/blob/master/packages/perspective-phosphor/src/ts/widget.ts#L319

This code should be

if (Array.isArray(data)) 
    if (data.length > 0{
        if (this._wrap) {
            this.pspNode.update([data]);
        } else {
            this.pspNode.update(data);
        }
    } else {
        console.warn('Perspective received length 0 data');
    }
} else {
...
@timkpaine timkpaine added bug Concrete, reproducible bugs JS Jupyter labels Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs JS Jupyter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timkpaine