Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on_update improvements #496

Closed
texodus opened this issue Mar 26, 2019 · 1 comment
Closed

on_update improvements #496

texodus opened this issue Mar 26, 2019 · 1 comment
Assignees
@sc1f
Labels
C++ enhancement Feature requests or improvements

Comments

@texodus
Copy link
Member

texodus commented Mar 26, 2019

{mode: "rows"} only currently works correctly with un-pivoted views - otherwise all rows are returned. In either case, this mode is very expensive as we are currently calculating deltas for every cell, then discarding this information and recalculating new rows based off the delta primary keys.

This should be re-implemented on the C++ side as a true primary key delta mode and reciprocal to_format() call structure which takes primary keys. It would also be nice to add a "cells" update mode which fully utilizes the underlying cell update code, as well as updates to the perspective-viewer API to utilize this information.
@texodus texodus added enhancement Feature requests or improvements C++ labels Mar 26, 2019
@sc1f sc1f self-assigned this Mar 28, 2019
@texodus
Copy link
Member Author

texodus commented May 30, 2019

This has been implemented and released in 0.3.0-rc.3

@texodus texodus closed this as completed May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sc1f sc1f

Labels
C++ enhancement Feature requests or improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@texodus @sc1f