Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JupyterLab plugin dist is broken - build/dist conversion #467

Closed
timkpaine opened this issue Mar 4, 2019 · 2 comments · Fixed by #673
Closed

JupyterLab plugin dist is broken - build/dist conversion #467

timkpaine opened this issue Mar 4, 2019 · 2 comments · Fixed by #673
Labels
bug Concrete, reproducible bugs Jupyter

Comments

@timkpaine
Copy link
Member

With the output assets moved to dist/ for voila, we need to point the jupyterlab extension at this as well, here
@timkpaine timkpaine added bug Concrete, reproducible bugs Jupyter labels Mar 4, 2019
This was referenced Mar 4, 2019
Closed
Merged
@timkpaine timkpaine mentioned this issue Apr 18, 2019
Closed
@timkpaine timkpaine reopened this Jul 30, 2019
@timkpaine
Copy link
Member Author

This has been broken again
https://github.com/finos/perspective/blob/master/packages/perspective-jupyterlab/src/config/plugin.config.js#L58

@timkpaine
Copy link
Member Author

https://github.com/finos/perspective/blob/master/packages/perspective-jupyterlab/package.json#L13

@timkpaine timkpaine mentioned this issue Jul 30, 2019
Merged
@timkpaine timkpaine mentioned this issue Mar 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs Jupyter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix jlab again finos/perspective
1 participant
@timkpaine