Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type for Filters in Typescript perspective-viewer/index.d.ts #1517

Closed
nekw opened this issue Aug 19, 2021 · 0 comments · Fixed by #1530
Closed

Incorrect type for Filters in Typescript perspective-viewer/index.d.ts #1517

nekw opened this issue Aug 19, 2021 · 0 comments · Fixed by #1530
Labels
bug Concrete, reproducible bugs
Milestone

Comments

@nekw
Copy link

nekw commented Aug 19, 2021

Bug Report

In https://github.com/finos/perspective/blob/master/packages/perspective-viewer/index.d.ts
line 31:
export type Filters = Array<[string, string, string]>;

I think this line should change to below or better types:
export type Filters = Array<[string, string, string | string[]>;

For example, the filters could be in following case involving 'in' operator
[
['field A', 'in', ['value 1', 'value2', 'value3']]
['field B', '==', 'value 4']
]

Steps to Reproduce:

N/A

Expected Result:

export type Filters = Array<[string, string, string | string[]>;

Actual Result:

export type Filters = Array<[string, string, string>;

Environment:

Finos/Perspective 0.10.0, ReactJS, Typescript

@texodus texodus added this to the 1.0.0 milestone Aug 25, 2021
@texodus texodus added the bug Concrete, reproducible bugs label Aug 25, 2021
@texodus texodus linked a pull request Sep 3, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants