Bug: Syncing issue when using XStore Association Mapping

[kshradhan]

🐛 Bug Report

Changes don't sync when using XStore Association Mapping.

Expected behavior

Workspace should sync without any unsynced file

Reproduction Code or Repo

Use this code

Class model::MapPerson
{
  firstName: String[1];
}

Class model::MapFirm
{
  firstName: String[1];
}

Class model::Person
{
  firstName: String[1];
  lastName: String[1];
}

Class model::Firm
{
  legalName: String[1];
}

Association model::FirmPerson
{
  firm: model::Firm[1];
  employee: model::Person[1];
}


###Mapping
Mapping model::NewMapping
(
  *model::Firm[firm]: Pure
  {
    ~src model::MapPerson
    legalName*: $src.firstName
  }
  *model::Person[person]: Pure
  {
    ~src model::MapFirm
    firstName: $src.firstName
  }

  model::FirmPerson: XStore
  {
    firm[person, firm]: $that.legalName == $this.firstName
  }
)

Possible Solution

This could be a hashing issue.

Additional context

[kshradhan]

legend-studio/packages/legend-graph/src/models/metamodels/pure/packageableElements/domain/PropertyReference.ts

Line 74 in a05f475

this.ownerReference.hashValue,

legend-studio/packages/legend-graph/src/models/protocols/pure/v1/model/packageableElements/domain/V1_PropertyPointer.ts

Line 31 in a05f475

this.class ?? '',

These two lines are the issue. on the line 31 of v1 property pointer, value of this.class comes out to be the correct model::FirmPerson

and on the line 74 in PropertyReferenc.ts the value for this.ownerReference.hashValue this comes out to be model::Person

also this following comment mentions this property to be implicit:

legend-studio/packages/legend-graph/src/models/protocols/pure/v1/transformation/pureGraph/to/V1_ProtocolToMetaModelPropertyMappingBuilder.ts

Line 753 in a05f475

// NOTE: this should be `implicit` because this comes from an association