Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Reference validation #323

Closed
2 tasks
akphi opened this issue Jul 8, 2021 · 1 comment
Closed
2 tasks

RFC: Reference validation #323

akphi opened this issue Jul 8, 2021 · 1 comment
Labels
Component: Graph Manager Issues related to graph processing and management (including interaction with engine server) logic Studio Core Team Opened by a member of the Studio core team Type: Discussion Type: Refactor
Milestone

Comments

@akphi
Copy link
Contributor

akphi commented Jul 8, 2021

One big concern we have is when we delete something, other parts of the app still keeps the reference to it. For example: class properties being referred to in class mappings, etc. Right now our strategy after deleting some element is quite inconsistent:

  • For deleting element, we do a full rebuild/recompile
  • For deleting sub-element, we do nothing

The former is a bit aggressive if we need to do this for every change. That being said, it might be useful to tell user when references are broken/invalid.

Implementation Plan

  • Add a flag isDeleted for places we want: element, property (basically for each type of reference)
  • Add a computed property to each reference (potentially for reference we can do a method isValid() always returning true by default, and we can override for each as we start supporting more and more things) -> this is good for graph validation checks in general. See RFC: Rework graph feedback #262
@akphi akphi added the Studio Core Team Opened by a member of the Studio core team label Oct 29, 2021
@akphi akphi changed the title RFC: Support reference validation Feature request: Support reference validation Nov 6, 2021
@akphi akphi changed the title Feature request: Support reference validation RFC: Reference validation Nov 6, 2021
@akphi akphi removed the good first issue Good for newcomers label Nov 6, 2021
@akphi akphi modified the milestones: Marathon, Backlog Nov 18, 2021
@akphi akphi added the Component: Graph Manager Issues related to graph processing and management (including interaction with engine server) logic label Feb 28, 2022
@akphi
Copy link
Contributor Author

akphi commented May 17, 2022

Closing in favor of #1168

@akphi akphi closed this as completed May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Graph Manager Issues related to graph processing and management (including interaction with engine server) logic Studio Core Team Opened by a member of the Studio core team Type: Discussion Type: Refactor
Projects
None yet
Development

No branches or pull requests

1 participant