Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Change Query text mode to be inside query window rather than a new modal #2009

Open
1 of 2 tasks
xannem opened this issue Mar 15, 2023 · 1 comment
Open
1 of 2 tasks
Labels
Component: Query Builder Issues related to query builder core Component: UX/Design Issues related to UI/UX features and improvements, style system, and design principle Studio Core Team Opened by a member of the Studio core team Type: Feature Request
Milestone

Comments

@xannem
Copy link
Contributor

xannem commented Mar 15, 2023

Similar requests

  • I have searched and found no existing similar requests

How are you using Legend?

Legend Query

What problems are you trying to solve?

When a user tries to edit a query directly in text mode, a new modal appears and serves as the location for the user to do so:
image

However, ideally the text mode version should just cause a switch to the current query builder modal rather than the overlay of a new modal
image
where the panels like the explorer, parameters, content, etc. panel are replaced with a window for the text mode.

Describe the solution you would like to see implemented

This will require more thought on what exactly we want to leave in during the text form switch (for example, we'd likely still want the headers and query-builder__sub-header with information like the title of the query to remain.

Describe alternatives you have considered

No response

Documentation, Design, Adoption, Migration Strategy

No response

Contribution

  • I would like to work on this feature
@xannem xannem added Type: Feature Request Component: Query Builder Issues related to query builder core Application: Query Issues related to Legend Query application Component: UX/Design Issues related to UI/UX features and improvements, style system, and design principle labels Mar 15, 2023
@github-actions github-actions bot added the Studio Core Team Opened by a member of the Studio core team label Mar 15, 2023
@github-actions github-actions bot added this to the Backlog milestone Mar 15, 2023
@akphi akphi modified the milestones: Backlog, On Deck, 10.0.0 Mar 16, 2023
@akphi akphi removed the Application: Query Issues related to Legend Query application label Mar 16, 2023
@akphi
Copy link
Contributor

akphi commented Mar 16, 2023

@xannem one thing to note is that the unsupported mode should by default show text, with the problem (which triggers unsupported mode) to show up somewhere. The other important thing to note here is to think about text mode almost like another view of form mode and structure the code that way like what we have in #1898

@github-actions github-actions bot modified the milestones: 10.0.0, 11.0.0 Jul 20, 2023
@github-actions github-actions bot modified the milestones: 11.0.0, 12.0.0 Dec 21, 2023
@github-actions github-actions bot modified the milestones: 12.0.0, 13.0.0 Jul 10, 2024
@akphi akphi modified the milestones: 13.0.0, On Deck Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Builder Issues related to query builder core Component: UX/Design Issues related to UI/UX features and improvements, style system, and design principle Studio Core Team Opened by a member of the Studio core team Type: Feature Request
Projects
None yet
Development

No branches or pull requests

2 participants