Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRAGMOS * whole Model benefit + required for Struct * - Enum type refactoring 2 - DateIsRelativeToEnum #2523

Closed
JBZ-Fragmos opened this issue Nov 15, 2023 · 3 comments

Comments

@JBZ-Fragmos
Copy link
Contributor

JBZ-Fragmos commented Nov 15, 2023

  • We want to add this new Enum type
  • and it will be a new attribute in existing type RelativeDate

image

Rationale :

this date is exactly same concept as the existing PayRelativeToEnum that currently points to CalculationPeriodDates, which purpose is to designate the type of dates the Payment Dates shall refer to among CalculationPeriodDates, for the purpose of anchoring, possibly calculate offset, etc.

we want to leverage this logic by making it more generic,
which means

  • to extend the list of Enum values as compared for instance to current list we have in PayRelativeToEnum
  • to consider that being relativeToEnum shall not be restricted to Payment Dates only i.e. any date being a RelativeDate (whether for valuation, payment, observation, etc;) shall have such Enum attribute with an extensive list so that it may refer to most usual types industry is actually using when booking trades and producing related termsheets e.g. Valuation Date, Termination Date, Observation Date, etc.

_note _ : as regards the Payment Date where current PayRelativeToEnum exists, we could remove it / replace it by the one we propose, that is generic so encompasses the particular business case of Payment Dates among other ones....

BACKGROUND
this is required for modelling Structured Product #2483
yet business usage of this component is not restricted to Structured Products, so shall benefit to the whole model

@JBZ-Fragmos JBZ-Fragmos changed the title FRAGMOS - Enum type refactoring 2 - NewDateRelativeToEnum FRAGMOS - Enum type refactoring 2 - DateIsRelativeToEnum Nov 24, 2023
@JBZ-Fragmos JBZ-Fragmos changed the title FRAGMOS - Enum type refactoring 2 - DateIsRelativeToEnum FRAGMOS * whole Model benefit + required for Struct * - Enum type refactoring 2 - DateIsRelativeToEnum Dec 6, 2023
@jiahaodengbb
Copy link

LGTM

@JBZ-Fragmos
Copy link
Contributor Author

@jiahaodengbb
thanks for your positive feedback (I assume "LGTM" means "Looks good to me")
FYI, i've just specified/distinguished between more types of termination dates ; for clarity i've juts added these ones compare to initial version you have hecked
image

business need / background :
new termsheet recently received (cannot disclose here, it is Client TS, will depend if agrees to join next Structured Meeting &/or share Termsheets) :

  • rate payoff in where number of days to count for calculating a multiplier value is duration between initial date and early observation event date that is to say a Term period i.e. end date cannot be fixed in advance, hence being relativeToEnum,EARLY_TERMINATION_OBSERVATION_DATE
  • and payment is 5 days after, so needed to define such offset as relativeToEnum,EARLY_TERMINATION_SETTLEMENT_DATE

@JBZ-Fragmos
Copy link
Contributor Author

any item related to this Issue is either closed or re-open under this one :
#2941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants