Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Close current tabs before closing the window #16367

Closed
kryzet opened this issue Oct 19, 2024 · 12 comments · Fixed by #16596
Closed

Bug: Close current tabs before closing the window #16367

kryzet opened this issue Oct 19, 2024 · 12 comments · Fixed by #16596
Assignees

Comments

@kryzet
Copy link

kryzet commented Oct 19, 2024

Description

Whenever I open Files after closing it, the screen that was previously open when I closed it appears briefly before the Home screen is loaded.

Steps To Reproduce

  1. Open Files.
  2. Navigate to a non-Home screen, such as a drive partition (C, D, etc.) or folder.
  3. Close Files.
  4. Open Files again.

Requirements

  • Flush GPU memory associated with a Files window when closing it.
  • Automatically navigate to the Home screen (or any other startup screen that has been configured) before closing the current window.

Files Version

3.7.11.0

Windows Version

10.0.22631.4317

@Josh65-2201
Copy link
Member

Thanks for the report, Can you send a screen recording of this.

@Josh65-2201 Josh65-2201 added the needs - additional info Needs more information from the reporter label Oct 19, 2024
@CloudTheWolf
Copy link

This sounds like you have the "Startup Settings" set to "Continue where you left off" instead of "Open a new tab"?
Image

Also, you may want to remove the log file as it has you email in there, which you might not want publicly visible (This is from your Google Driver and One Drive providers)

@kryzet
Copy link
Author

kryzet commented Oct 24, 2024

This sounds like you have the "Startup Settings" set to "Continue where you left off" instead of "Open a new tab"? Image

Image

Also, you may want to remove the log file as it has you email in there, which you might not want publicly visible (This is from your Google Driver and One Drive providers)

Thank you very much! I appreciate that you let me know.

@kryzet
Copy link
Author

kryzet commented Oct 24, 2024

Thanks for the report, Can you send a screen recording of this.

The problem is, if I make a recording of this it will likely reveal a folder with files I have in it, and I'm not sure how to redact that information from the video. I tried setting the startup directory to a Windows library and reproducing the issue, but it didn't occur.

@yaira2
Copy link
Member

yaira2 commented Oct 27, 2024

What option do you have set for the startup setting?

@kryzet
Copy link
Author

kryzet commented Oct 27, 2024

I already shared a screenshot of the current startup setting. I tried to set it to open a specific page (a Windows Library) and then attempted to reproduce the issue, but that was in vain.

@yaira2
Copy link
Member

yaira2 commented Oct 27, 2024

My apologies, I missed the earlier comments. Is everything good now?

@kryzet
Copy link
Author

kryzet commented Oct 27, 2024

It's fine. We all miss things from time to time. As for your question, no; the issue persists. It's just that I can't record a video to demonstrate it.

@yaira2 yaira2 changed the title Bug: Previous Screen Appears When Launching Bug: Close current tabs before closing the window Oct 28, 2024
@yaira2 yaira2 removed the needs - additional info Needs more information from the reporter label Oct 28, 2024
@yaira2
Copy link
Member

yaira2 commented Oct 28, 2024

Is this correct?

  1. Set startup setting to "Open new tab".
  2. Navigate to a folder (eg. Downloads).
  3. Close the window (with the option to keep Files running in the background enabled).
  4. Open Files and the previous location is briefly shown before the app navigates to the home page.

@yaira2 yaira2 added the needs - additional info Needs more information from the reporter label Oct 28, 2024
@yaira2
Copy link
Member

yaira2 commented Nov 4, 2024

@hishitetsu this seems to occur because the existing tab list is only cleared when resuming the session. Do you recall if there was a limitation that caused us to write the logic this way?

@hishitetsu
Copy link
Member

I believe the tab list is cleared before sleep. But subsequent UI updates are asynchronous, so I think this problem is caused by the UI update not completing before sleep.

@yaira2
Copy link
Member

yaira2 commented Dec 11, 2024

I opened a pull request to resolve this issue #16596

@yaira2 yaira2 moved this from 🆕 New to 🏗 In progress in Files task board Dec 11, 2024
@yaira2 yaira2 removed the needs - additional info Needs more information from the reporter label Dec 11, 2024
@yaira2 yaira2 self-assigned this Dec 11, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
5 participants