Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STM] Start annotations on venus-messager #5273

Closed
Fatman13 opened this issue Sep 7, 2022 · 1 comment · Fixed by ipfs-force-community/sophon-messager#255
Closed

[STM] Start annotations on venus-messager #5273

Fatman13 opened this issue Sep 7, 2022 · 1 comment · Fixed by ipfs-force-community/sophon-messager#255
Assignees
@zl03jsj
Labels
C-need-testing Category: Venus testing related CU-System-Test-Matrix Category: STM related issues P2 Medium - we should get to this soon

Comments

@Fatman13
Copy link
Contributor

Fatman13 commented Sep 7, 2022

No description provided.

@Fatman13 Fatman13 added C-need-testing Category: Venus testing related CU-System-Test-Matrix Category: STM related issues labels Sep 7, 2022
@zl03jsj
Copy link
Contributor

zl03jsj commented Sep 7, 2022 •
edited
Loading

Since the GasEstimateMessageGas of messageSelector is deprecated, and will be removed soon.
https://github.com/filecoin-project/venus-messager/blob/632f7b8e48049dbbfe4ca7235975f7f87ef62721/service/message_selector.go#L350-L380

There is no necessary to keep its catalogs in STM now:
https://github.com/filecoin-project/system-test-matrix/blob/cd7e06431903b3892b693db68a51ca03c493ea79/frontend/apps/web/scripts/data/systems/venus-messenger/message_selector.yml#L13-L33

@bokimilinkovic @StefanGajic

@Fatman13 Fatman13 added the P2 Medium - we should get to this soon label Sep 7, 2022
@zl03jsj zl03jsj moved this to In Progress in Venus Project Sep 7, 2022
@zl03jsj zl03jsj mentioned this issue Sep 7, 2022
Merged
5 tasks
Repository owner moved this from In Progress to Done in Venus Project Sep 13, 2022
@zl03jsj zl03jsj mentioned this issue Sep 14, 2022
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zl03jsj zl03jsj

Labels
C-need-testing Category: Venus testing related CU-System-Test-Matrix Category: STM related issues P2 Medium - we should get to this soon
Projects
Venus Project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add testing annotations for STM ipfs-force-community/sophon-messager
2 participants
@Fatman13 @zl03jsj