Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fil-Plus Subsequent Allocation bot report wrong statistic #840

Closed
NiwanDao opened this issue Mar 1, 2023 · 1 comment
Closed

Bug: Fil-Plus Subsequent Allocation bot report wrong statistic #840

NiwanDao opened this issue Mar 1, 2023 · 1 comment
Assignees
Labels
Proposal For Fil+ change proposals

Comments

@NiwanDao
Copy link

NiwanDao commented Mar 1, 2023

Issue Description

When multiple LDN shares the same client address, the subsequent allocation miscalculates the ratio of remaining Datacap / Datacap allocation, which does not kick off the readyToSign bot appropriately.

For example, LDN #1143 and LDN #1144
share the same client address f1mmtovvurlhcvfmqbww6nzwwrse3cljccjmdftki. As shown in the screenshot from https://filplus.d.interplanetary.one/, 3.5PiB was granted to the address, and the available Datacap is 600Tib. The ratio to trigger the next tranche of Datacap allocation is reached as current ratio is 16.7%(600Tib / 3.5Pib ) and is below 25%. However, Filecoin Log Explorer expose the different ratio. See attached of log #1143 and #1144 below.

截屏2023-03-01 下午2 48 00

截屏2023-03-01 下午2 52 45

截屏2023-03-01 下午2 53 14

Impact

largely increase the TTD and bad user experience.

Proposed Solution(s)

Manually unblock the Datacap signing process until the bug fixed.

Timeline

Technical dependencies

End of POC checkpoint (if applicable)

Risks and mitigations

Related Issues

LDN #1143 and LDN #1144

@NiwanDao NiwanDao added the Proposal For Fil+ change proposals label Mar 1, 2023
@panges2
Copy link
Collaborator

panges2 commented Mar 1, 2023

Hi @xingjitansuo, this error has been noted. We seem to encounter errors when different LDN applications have the same client address. We know this is not the ideal use experience, and we are trying to improve this in the future.

This could also be because of the DMOB API migrations that happened a few days ago. There were problems with accessing the API that SA bot uses to read remaining datacap. We have already solved this problem.

For now, if you can, try switching the client address on the older application, and contact me on slack if you need help @philippe Pangestu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposal For Fil+ change proposals
Projects
None yet
Development

No branches or pull requests

4 participants