Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NV18: Confirm tooling that assumes knowledge of method params / returns don't break #9776

Closed
arajasek opened this issue Dec 2, 2022 · 4 comments
Assignees
Labels
P2 P2: Should be resolved
Milestone

Comments

@arajasek
Copy link
Contributor

arajasek commented Dec 2, 2022

We have tooling that can be used to encode / decode the params & return value of messages. This is important to support for builtin-actors, but cannot be supported for user-defined actors. We need to make sure that such tooling gracefully fails in this case.

@arajasek arajasek moved this to 📋 Backlog in Network v18 Dec 2, 2022
@jennijuju jennijuju added this to the Network v18 milestone Dec 5, 2022
@jennijuju jennijuju added the P2 P2: Should be resolved label Dec 5, 2022
@jennijuju
Copy link
Member

can be a thing happen during calibration

@jennijuju jennijuju moved this from 📋 Nice To Haves to 🌟 In Scope in Network v18 Dec 7, 2022
@scotthconner
Copy link

Is this client side tooling, or libraries/functions inside of lotus itself? Trying to understand this item.

@jennijuju
Copy link
Member

@scotthconner in lotus cli/api

@arajasek
Copy link
Contributor Author

The best way to confirm this is to call lotus chain decode params with the params supplied to messages that deploy and invoke contracts on a devnet / testnet. We expect the "outer" params to decode correctly, but not those that are actually passed to the contract.

More importantly, no panicking / ugly failing.

@jennijuju jennijuju moved this from 🌟 In Scope to 🏗 In progress in Network v18 Jan 16, 2023
@jennijuju jennijuju moved this from 🏗 In progress to 👀 In review in Network v18 Feb 6, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Network v18 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 P2: Should be resolved
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants