Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR: failed to resolve ID address: %!w(address.Address={}) #7919

Closed
8 of 18 tasks
SealStorage-Jacques opened this issue Jan 11, 2022 · 4 comments · Fixed by #11273
Closed
8 of 18 tasks

ERROR: failed to resolve ID address: %!w(address.Address={}) #7919

SealStorage-Jacques opened this issue Jan 11, 2022 · 4 comments · Fixed by #11273
Labels
area/ux Area: UX dif/easy An existing lotus user should be able to pick this up effort/minutes good first issue Good for newcomers kind/bug Kind: Bug P2 P2: Should be resolved

Comments

@SealStorage-Jacques
Copy link

Checklist

  • This is not a security-related bug/issue. If it is, please follow please follow the security policy.
  • This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not an enhancement request. If it is, please file a improvement suggestion instead.
  • I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
  • I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to lotus.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Lotus Version

Daemon:  1.13.1+mainnet+git.8943de27e.dirty+api1.4.0
Local: lotus version 1.13.1+mainnet+git.8943de27e.dirty

Describe the Bug

We recently switched to f2 multisig owner actor on our SP which is requirement from our FIL lender, we're also using bidbot to accept deals onto our SP and bidbot requires a signator against the SP owner account, when running lotus wallet sign on the new owner address it errors with:
ERROR: failed to resolve ID address: %!w(address.Address={})
I also noticed the following error on the SP side running lotus-miner actor control list produces error:
getting account key: failed to get account actor state for [SP-id] unknown actor code [baf....]

Logging Information

Lotus Log:
2022-01-10T19:37:26.767-0500	WARN	rpc	go-jsonrpc@v0.1.5/handler.go:279	error in RPC call to 'Filecoin.WalletSign': failed to resolve ID address: %!w(address.Address={}):
    github.com/filecoin-project/lotus/node/impl/full.(*WalletAPI).WalletSign
        /lotus/lotus/node/impl/full/wallet.go:41

Repo Steps

  1. Change SP owner address to f2 multisig actor.

  2. Try to sign a message against: lotus wallet sign f2....

  3. Run: lotus-miner actor control list

@jennijuju jennijuju added area/ux Area: UX dif/easy An existing lotus user should be able to pick this up effort/minutes LotusY-2 P2 P2: Should be resolved and removed need/triage labels Jan 11, 2022
@jennijuju jennijuju added this to LotusY Jan 11, 2022
@jennijuju jennijuju moved this to Ready To Work in LotusY Jan 11, 2022
@jennijuju
Copy link
Member

jennijuju commented Jan 11, 2022

The improvement lotus should do here is to wrap the error better.

@jennijuju
Copy link
Member

jennijuju commented Jan 11, 2022

The reproduction step suggests that an user misbehaved and led to the error- multisig is an actor account that doesn’t have keys to sign transactions. To send a message using multisg , singers of the multisig need to propose and approve messages (based on the threshold) refer to lotus doc for the usage of multisg.

@arajasek
Copy link
Contributor

arajasek commented Feb 8, 2022

I agree with @jennijuju here -- there is easy UX improvements that can be made to handle multisig owners better. We can definitely improve the output of lotus-miner actor control list, and maybe provide a better error for lotus wallet sign. We can also audit other lotus-miner UX commands to see if they work gracefully with multisig owners.

I'm not sure if that actually solves @SealStorage-Jacques's problem, though -- not clear exactly what is needed.

@rjan90
Copy link
Contributor

rjan90 commented Aug 8, 2022

So this is half fixed:

lotus-miner actor control list produces error:
getting account key: failed to get account actor state for [SP-id] unknown actor code [baf....]

Has been fixed with #9072.

So the only thing missing is wrapping the error better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux Area: UX dif/easy An existing lotus user should be able to pick this up effort/minutes good first issue Good for newcomers kind/bug Kind: Bug P2 P2: Should be resolved
Projects
Status: Closed
Status: Closed
Development

Successfully merging a pull request may close this issue.

5 participants