Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] when we build a ProveCommitAggregate msg, we should set value is collateral + aggFee #6622

Closed
firesWu opened this issue Jun 29, 2021 · 1 comment
Labels
kind/bug Kind: Bug

Comments

@firesWu
Copy link
Contributor

firesWu commented Jun 29, 2021

Note: For security-related bugs/issues, please follow the security policy.

Describe the bug

mcid, err := b.api.SendMsg(b.mctx, from, b.maddr, miner.Methods.ProveCommitAggregate, collateral, maxFee, enc.Bytes())

why only send collateral to miner, it should send collateral + aggFee.
if we only send collateral, ProveCommitAggregate was report this error.

https://github.com/filecoin-project/specs-actors/blob/f7d531232aa2b5dfe6c040d1703eaaaf9dad4668/actors/builtin/miner/miner_actor.go#L967

if people initialize a new miner, ProveCommitAggregate will exec failed until people send some fil to miner

Version (run lotus version):

v1.10.0

Expected behavior

it should send collateral + aggFee to miner when send ProveCommitAggregate msg

@arajasek
Copy link
Contributor

arajasek commented Jul 3, 2021

Closed by #6625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug
Projects
None yet
Development

No branches or pull requests

3 participants