Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support early finalization before commit #6431

Closed
Tracked by #6185
jennijuju opened this issue Jun 9, 2021 · 2 comments · Fixed by #6452
Closed
Tracked by #6185

Support early finalization before commit #6431

jennijuju opened this issue Jun 9, 2021 · 2 comments · Fixed by #6452
Assignees
Labels
area/sealing effort/days Effort: Multiple Days P1 P1: Must be resolved

Comments

@jennijuju
Copy link
Member

Currently lotus finalizing the sectors locally after sectors are onchain, however if a something goes wrong in the FinalizeSector step, miners won’t be able to proving it and will have to terminate the sectors.

Allow early finalization can prevent it bit.

This is also important with ProveCommitAggregate, it may trigger a large amount of transfers from worker to the miner and can be too heavy for miners current setup to handle. Although ParallelFetchLimit can help a little with that.. it’s not ideal. It will be ideal if we can have #5339 , but for now, have an option for early finalization helps too.

@jennijuju jennijuju added effort/days Effort: Multiple Days P1 P1: Must be resolved area/sealing labels Jun 9, 2021
@jennijuju jennijuju added this to the Network Hyperdrive milestone Jun 9, 2021
@jennijuju jennijuju mentioned this issue Jun 9, 2021
80 tasks
@hxg8202
Copy link

hxg8202 commented Jun 10, 2021

It is important

@s1mple1122
Copy link
Contributor

if sector wait ProCommitAggregate ,sector Will it go to the next step, or is it just waiting ?

@magik6k magik6k linked a pull request Jun 11, 2021 that will close this issue
@BigLep BigLep closed this as completed Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sealing effort/days Effort: Multiple Days P1 P1: Must be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants