Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpool gets into bad state after reorgs #561

Closed
whyrusleeping opened this issue Nov 9, 2019 · 2 comments
Closed

Mpool gets into bad state after reorgs #561

whyrusleeping opened this issue Nov 9, 2019 · 2 comments

Comments

@whyrusleeping
Copy link
Member

If you are sending a lot of messages, and the chain reorgs (and you are using BLS messages) your mempool will get into a bad state where the lowest nonce of any message in the mempool is higher than your actors nonce on chain, but any further messages you send will be given the next highest nonce of any message you have in the mempool.

Two things we can do to improve this situation (we should do both):

  • Fix handling of BLS messages during reorgs (Requires saving bls messages signatures separately in a place we can get them again)
  • Detect nonce gaps in the message pool when requesting future nonces
@magik6k
Copy link
Contributor

magik6k commented Nov 12, 2019

#581

@whyrusleeping
Copy link
Member Author

The BLS portion of this issue is done.

@magik6k magik6k closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants