Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log settings not persistent #5138

Closed
shawnp0wers opened this issue Dec 7, 2020 · 3 comments · Fixed by #8283
Closed

Log settings not persistent #5138

shawnp0wers opened this issue Dec 7, 2020 · 3 comments · Fixed by #8283

Comments

@shawnp0wers
Copy link

Describe the bug
When adjusting which events appear in the log (using lotus-miner log set-level --system xxx), the settings only persist until the miner is restarted. If they could be set in config, or persisted in some other way, it would be ideal.

To Reproduce
Change log setting. Restart miner. Log settings revert to default.

Expected behavior
Settings stick, or another method to set desired log levels.

Version (run lotus version):
Daemon: 1.2.2+git.b13226bc2.dirty+api1.0.0
Local: lotus version 1.2.2+git.b13226bc2.dirty

@Kubuxu
Copy link
Contributor

Kubuxu commented Dec 7, 2020

I would like to avoid adding a persistent state to logging it can be problematic.
We could consider adding per-system log level via env-vars.

@f8-ptrk
Copy link
Contributor

f8-ptrk commented Dec 16, 2020

while on it: it would be great if we could not only set but query the levels of a system

@Stebalien
Copy link
Member

See ipfs/go-log#100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants