Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devnet epoch durations do not reflect changes to BlockDelaySecs #4413

Closed
ribasushi opened this issue Oct 15, 2020 · 2 comments
Closed

Devnet epoch durations do not reflect changes to BlockDelaySecs #4413

ribasushi opened this issue Oct 15, 2020 · 2 comments

Comments

@ribasushi
Copy link
Collaborator

Describe the bug

Devnet is built with the following modification to block-minting times: https://github.com/filecoin-project/lotus/blob/master/build/params_2k.go#L42

Yet none of the constants here follow https://github.com/filecoin-project/specs-actors/blob/v0.9.12/actors/builtin/network.go#L9-L21

This, among other effects, prevents deal-making in a local devnet.

@rjan90
Copy link
Contributor

rjan90 commented Jul 4, 2022

The deal making command now gets block delay specific to the build: #8896. So I guess this issue can be closed now?

@ribasushi
Copy link
Collaborator Author

Probably!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants