Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of duration of a storage deal set ask #4076

Closed
jennijuju opened this issue Sep 28, 2020 · 2 comments · Fixed by #4077
Closed

Use of duration of a storage deal set ask #4076

jennijuju opened this issue Sep 28, 2020 · 2 comments · Fixed by #4077
Labels
area/markets Area: Markets

Comments

@jennijuju
Copy link
Member

For lotus-miner storage-deals set ask, there is an duration param option with description Set duration of ask (a quantity of time after which the ask expires) DURATION (default: 720h0m0s).

By the sounds of it, it gives the expression that the miner will stop accepting deals in 720 hr(by default)(like the miner only asking for deals with this price in the next 720hr)

However from @hannahhoward , while we have a notion of an expiration, we actually don't do anything with it (miner will be still accepting deals after the duration passes.

We should figure out what we want to do with it.

@jennijuju jennijuju added the area/markets Area: Markets label Sep 28, 2020
@arajasek
Copy link
Contributor

Update from a quick convo: We should probably get rid of the idea of duration, for now, let's hide this option from the CLI.

@jennijuju
Copy link
Member Author

For now - we decided to remove that option from the CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/markets Area: Markets
Projects
None yet
2 participants