Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2rd Community Review of Filscanteam Allocator #222

Closed
FilscanOfficial opened this issue Nov 11, 2024 · 4 comments
Closed

2rd Community Review of Filscanteam Allocator #222

FilscanOfficial opened this issue Nov 11, 2024 · 4 comments
Assignees
Labels
DataCap - Refreshed Refresh Applications received from existing Allocators for a refresh of DataCap allowance

Comments

@FilscanOfficial
Copy link

Allocator application filecoin-project/notary-governance#1033

Our second batch of 5PiB is about to be consumed.
Two new clients were added in this round:
FilscanOfficial/filscan-backend#23
FilscanOfficial/filscan-backend#21
There is also an old client that continues to supply:
FilscanOfficial/filscan-backend#17

Compared with the first batch, we have made the following improvements and report them here:

  1. Disclose all client application information on GitHub to provide evidence for due diligence;
  2. When the client has changed information, let them change the application in time;
  3. In order to improve the retrieval rate, it is recommended that the client stop using DDO to issue orders, and require all to improve the retrieval rate;

Since the demand of the three clients that are still in supply has not been met, and we also hope to attract more clients to join filecoin, so this round hopes to supply 10PiB, thank you very much!

@filecoin-watchdog filecoin-watchdog added the Awaiting Community/Watchdog Comment DataCap Refresh requests awaiting a public verification of the metrics outlined in Allocator App. label Nov 12, 2024
@Kevin-FF-USA Kevin-FF-USA self-assigned this Nov 12, 2024
@filecoin-watchdog
Copy link
Collaborator

@FilscanOfficial This is the 2nd review, not the 3rd :)
Allocator Application
Compliance Report
1st Review
1st Review score: 5PiB

5 PiB granted to clients:

Client Name DC status
ABGAasia 1.13PiB New
DuitangInformation Technology (Shanghai) Co., Ltd. 3.67PiB New
FileDriveLabs 0.2PiB Existing

ABGAasia

  • KYB completed via email.
  • Dataset already stored on Filecoin: Issue #872.
  • Insufficient information on data preparation (missing from the form; allocator did not request it).
  • SPs used for deals align with the provided or updated list.
  • Majority of SPs located in the same region.
  • Low retrieval rate.

Duitang Information Technology (Shanghai) Co., Ltd

  • KYB completed via email.
  • 200 TiB granted for testing after KYB/KYC.
  • SPs used for deals align with the provided or updated list.
  • Good retrieval and replication performance.

FileDriveLabs

  • SPs used for deals align with the provided or updated list.
  • Two SPs sealed excessive data (f02984331, f02883857).

@filecoin-watchdog filecoin-watchdog added Awaiting Response from Allocator If there is a question that was raised in the issue that requires comment before moving forward. and removed Awaiting Community/Watchdog Comment DataCap Refresh requests awaiting a public verification of the metrics outlined in Allocator App. labels Nov 26, 2024
@FilscanOfficial FilscanOfficial changed the title 3rd Community Review of Filscanteam Allocator 2rd Community Review of Filscanteam Allocator Nov 27, 2024
@FilscanOfficial
Copy link
Author

@filecoin-watchdog
I am very happy to receive your reply. Thank you for pointing out my error. I have corrected the third time to the second time.
For my current shortcomings, I will make dissolution and improvement measures here:
FilscanOfficial/filscan-backend#21

  • The dataset has been stored on Filecoin: [DataCap Application] Asia Blockchain Gaming Alliance filecoin-plus-large-datasets#872.
    I asked the client and he explained that since it has been a long time, there have been personnel changes and new data has been generated, so I applied again. Before the next round of approval, I will ask them to provide more data samples for review.
    image

  • Insufficient information on data preparation (missing from the form; allocator did not request it).
    This is my mistake. I ignored the strict review of private data sets. I will improve it in the future through the following means

  1. Download data from the IP specified by the customer for review.
  2. Ask the customer to provide more data samples when applying for connection.
  3. Ask the customer to provide more data samples for review by email.
  • Majority of SPs located in the same region.
    When I applied for allcator, I did not restrict the customer's region, because I think that assigning different SPs can ensure data security. Of course, we can also suggest customers to try to assign regions in the future.

  • Low retrieval rate.
    For SPs with poor retrieval results, I will ask the client to explain and elaborate on the improvement plan (in the first round of testing, one SP was not retrieved, and I followed up the reason in time)
    image
    image
    Client solved their problems and retrieval improved,I will continue to pay attention to the retrieval rate in the future.
    image

FilscanOfficial/filscan-backend#17

  • Two SPs sealed excessive data (f02984331, f02883857).
    In this round, I first provided 200T for testing, and they packed 40T for each of the 5 SPs, which met the requirements. Since he is an old customer, the report contains historical data, so it shows that the 2 SPs packed too much data. I controlled this round more strictly, so after testing the average distribution of the 5 SPs, I still asked the other party to explain the subsequent distribution plan, and I could only approve it after the other party responded. (The SP that does not show the search is the DDO node of the previous round)
    image
    image

Finally, thank you again for your hard work in helping me review compliance. In the future, I will become more and more standardized and strive to introduce more outstanding customers to join filecoin. I wish you a happy work!

@filecoin-watchdog filecoin-watchdog added Diligence Audit in Process Governance team is reviewing the DataCap distributions and verifying the deals were within standards Refresh Applications received from existing Allocators for a refresh of DataCap allowance and removed Awaiting Response from Allocator If there is a question that was raised in the issue that requires comment before moving forward. labels Nov 27, 2024
@Kevin-FF-USA
Copy link
Collaborator

Hi @FilscanOfficial

As more of these refresh requests are processed, greater adherence to the diligence plans in each pathways application will need to be maintained in order to justify receiving additional DC to distribute. Thanks for providing the additional context on these distributions, makes it helpful to understand the clients and how you are working to support them.

Next step is this application will receive a final review from Galen next week.
This review will take into account the retrieval rates, Bookkeeping documentation, SPs, As well as past issues that were identified in previous refreshes. If you have any questions please a comment here in issue, otherwise you will see guidance next week.

Warmly,
-Kevin

@galen-mcandrew
Copy link
Collaborator

Seeing good compliance and engagement here, and appreciate the diligence information provided. As noted, some areas to focus on going forwards:

  • investigating extraneous and redundant datasets across the Filecoin ecosystem, and encouraging data preparers to justify
  • requiring more details about data preparation methods in general
  • increasing retrieval rates and regional distribution

To support these improvements, we are requesting an additional 5PiB of DataCap.

@Kevin-FF-USA Kevin-FF-USA added DataCap - Refreshed and removed Diligence Audit in Process Governance team is reviewing the DataCap distributions and verifying the deals were within standards labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataCap - Refreshed Refresh Applications received from existing Allocators for a refresh of DataCap allowance
Projects
None yet
Development

No branches or pull requests

4 participants