Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot read property 'format' of null (+1) #32

Closed
arnars opened this issue Jun 1, 2016 · 4 comments
Closed

Uncaught TypeError: Cannot read property 'format' of null (+1) #32

arnars opened this issue Jun 1, 2016 · 4 comments
Labels

Comments

@arnars
Copy link

arnars commented Jun 1, 2016

Hi, it's me again. Sorry for all these issues, but we're really just enjoying using react-kronos, and the sometimes things pops up!

  1. Open http://dubert.github.io/react-kronos/
  2. Place the cursor in the first input date field
  3. Hit backspace until no more content is in the field
  4. Hit enter
  5. Watch the console - the above error should pop up.

+1

Also - in our solution (not on your site) I get an error extra between 4 and 5. When the input field is empty I get this:

Warning: `value` prop on `input` should not be null. Consider using the empty string to clear the component or `undefined` for uncontrolled components.

I can't seem to find out which event (if any?) the Kronos triggers when deleting content via backspace. These errors could be related, so my guess is that if you fix the first, mine will be fixed as well.

Again - thanks for your always swift replies and fixes! :-)

@arnars
Copy link
Author

arnars commented Jun 1, 2016

This could be related to the last issue: facebook/react#5048 - it's a part of the changelog at https://facebook.github.io/react/blog/

@felixakiragreen
Copy link
Owner

Hey @arnars ! Thanks for reporting this issue.

Should be fixed in 1.2.5 - let me know if you encounter any more issues!

@arnars
Copy link
Author

arnars commented Jun 3, 2016

Dear @DUBERT,

You rock!
I have no issues now, thanks to your update. It's a real pleasure using a plugin that is so consistently maintained. Thank you.

@felixakiragreen
Copy link
Owner

Thank you! It's always nice to hear positive feedback from people using my component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants