Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine all bugzilla comments #146

Open
jeremycline opened this issue Dec 21, 2016 · 1 comment
Open

Combine all bugzilla comments #146

jeremycline opened this issue Dec 21, 2016 · 1 comment

Comments

@jeremycline
Copy link
Member

Right now the-new-hotness adds a lot of comments (which in turn generates a lot of emails) when it files an issue. It would be nicer to combine everything into the initial report, or perhaps the initial report and a single comment.

The downside to pushing everything into a single report is that there's a large period of time where something can go wrong/the service is restarted and we lose the state and fail to report the new version.

@Zlopez
Copy link
Contributor

Zlopez commented May 6, 2022

Here is the current situation:

  1. 1 comment for new version
  2. 1 comment if anything happens during start of the scratch build
  3. 1 comment for attachment being added
  4. 1 comment for output of the scratch build

We can easily put together 1 and 2, we just add the bugzilla comment after scratch build was started (with the current implementation, we always get exception when something happens during the start of scratch build). 3 is currently not possible to merge with the previous one, because it's separate bugzilla API call. And the 4 is happening asynchronously to previous one.

So the best we can do right now is put 1 and 2 together. Which will lower the amount of updates by one. Not ideal, but something to go with.

With Redis implementation of the cache we can probably save the whole notification till the scratch build finishes and then do just two updates - one for the whole comment and one for attachment. Then the maximum amount of updates will be 2 even with scratch build enabled, but the cons here is that the notification will be available later than now, after scratch build will be finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants