Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python SDK to support labels #663

Closed
woop opened this issue Apr 29, 2020 · 4 comments · Fixed by #707
Closed

Update Python SDK to support labels #663

woop opened this issue Apr 29, 2020 · 4 comments · Fixed by #707
Labels
area/sdks good first issue Good for newcomers kind/feature New feature or request
Milestone

Comments

@woop
Copy link
Member

woop commented Apr 29, 2020

This issue follows #463 which has a partial implementation in #536.

One additional PR is needed to get #436 into a consistent and complete state for end users. Currently #536 makes changes to Feast Core by adding support for labels to feature sets and features, but it doesn't add support for labels to feature sets in the Python SDK.

The task here is to add this support and update any end-to-end tests that test both the Python SDK and Feast Core w.r.t label metadata.

@woop woop added this to the v0.5.0 milestone Apr 29, 2020
@woop woop added area/sdks kind/feature New feature or request labels Apr 29, 2020
@woop
Copy link
Member Author

woop commented May 3, 2020

Unless there is any objection then I think we can push this out to 0.6. We'd be introducing new API methods and not taking anything away? I don't see a compelling reason to block 0.5 over this.

@woop woop modified the milestones: v0.5.0, v0.6.0 May 3, 2020
@ches
Copy link
Member

ches commented May 4, 2020

Sounds reasonable, I also think this could be a great community contribution if there's someone wishing to use this functionality from the Python SDK who can prioritize it before the maintainers are able to.

@ches ches added the good first issue Good for newcomers label May 4, 2020
@Joostrothweiler
Copy link
Contributor

I would be happy to pick this up somewhere next week. From #463:

with the Python SDK having a set_label(key, value) method and a remove_label(key) method on the Feature class. list_feature_sets() would print out this information as well, but filtering will be left for a future release.

The idea is still to implement the 2 suggested functions and update list_feature_sets() right?

@woop
Copy link
Member Author

woop commented May 11, 2020

Hi @Joostrothweiler, that would be great!

Correct, it's about adding those to the feature set as opposed to the feature. Methods like list_feature_sets() should also be tested to see that they expose this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdks good first issue Good for newcomers kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants