Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaDataSource to allow for additional Kafka Settings #4894

Open
zerafachris opened this issue Jan 5, 2025 · 1 comment
Open

KafkaDataSource to allow for additional Kafka Settings #4894

zerafachris opened this issue Jan 5, 2025 · 1 comment
Labels
kind/feature New feature or request

Comments

@zerafachris
Copy link

Is your feature request related to a problem? Please describe.
The current implementation of KafkaSource should also allow for additional kafka settings as per https://kafka.apache.org/documentation.html#consumerconfigs and https://kafka.apache.org/documentation.html#producerconfigs.

For example, in a kafka implementation with SSL Security Protocol, the current kafka stream cannot be used.

Describe the solution you'd like
The KafkaOptions (https://rtd.feast.dev/en/master/_modules/feast/data_source.html#KafkaOptions) class should be extended to allow for https://kafka.apache.org/documentation.html#consumerconfigs and https://kafka.apache.org/documentation.html#producerconfigs settings.

As a starting point, maybe focus on security and then move to additional consumering/producing parameterization. Security parameters could be something like: security_protocol, ssl_context, sasl_mechanism, sasl_plain_username, sasl_plain_password. See AIOKafka API (https://aiokafka.readthedocs.io/en/stable/api.html) for a mapping of Kafka settings to consumer and producer apis.

Alternatively, use AIOKafka directly as Feast Kafka engine? [Apologies but could not find the current Kafka engine used by Feast]

Describe alternatives you've considered
Nothing yet.

Additional context
Not applicable.

@zerafachris
Copy link
Author

Need help with this PR #4902 which tries and address this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant